git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-compat-util: add generic find_last_dir_sep that respects is_dir_sep

From
Pascal Obry <pascal@obry.net>
Date
Aug 5, 2011, 16:10 UTC
Message-ID
<1312560614-20772-2-git-send-email-pascal@obry.net>
In-Reply-To
<1312560614-20772-1-git-send-email-pascal@obry.net>
From: Theo Niessink <theo@taletn.com>

Move MinGW's find_last_dir_sep to git-compat-util.h, so it can also be used on other platforms that define is_dir_sep, e.g. Cygwin.

Signed-off-by: Theo Niessink <theo@taletn.com>
Acked-by: Pascal Obry <pascal@obry.net>
---
 compat/mingw.h    |    9 ---------
 git-compat-util.h |   12 ++++++++++++
 2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/compat/mingw.h b/compat/mingw.h
index ce9dd98..547568b 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -300,15 +300,6 @@ int winansi_fprintf(FILE *stream, const char *format, ...) __attribute__((format
 
 #define has_dos_drive_prefix(path) (isalpha(*(path)) && (path)[1] == ':')
 #define is_dir_sep(c) ((c) == '/' || (c) == '\\')
-static inline char *mingw_find_last_dir_sep(const char *path)
-{
-	char *ret = NULL;
-	for (; *path; ++path)
-		if (is_dir_sep(*path))
-			ret = (char *)path;
-	return ret;
-}
-#define find_last_dir_sep mingw_find_last_dir_sep
 #define PATH_SEP ';'
 #define PRIuMAX "I64u"
 
diff --git a/git-compat-util.h b/git-compat-util.h
index ddfbf77..c2c94cd 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -211,6 +211,18 @@ extern char *gitbasename(char *);
 #define has_dos_drive_prefix(path) 0
 #endif
 
+#if !defined(find_last_dir_sep) && defined(is_dir_sep)
+static inline char *compat_find_last_dir_sep(const char *path)
+{
+	char *ret = NULL;
+	for (; *path; ++path)
+		if (is_dir_sep(*path))
+			ret = (char *)path;
+	return ret;
+}
+#define find_last_dir_sep compat_find_last_dir_sep
+#endif
+
 #ifndef is_dir_sep
 #define is_dir_sep(c) ((c) == '/')
 #endif
-- 
1.7.6.404.g5d2fc
Previous: Pascal ObryNext: Pascal Obry
Message 2 of 19 in “[PATH 0/2] On Cygwin support both UNIX and DOS style path-names”
  1. Pascal ObryAug 5, 2011
  2. 1/2 git-compat-util: add generic find_last_dir_sep that respects is_dir_sepPascal Obry, Aug 5, 2011
  3. 2/2 On Cygwin support both UNIX and DOS style path-namesPascal Obry, Aug 5, 2011
  4. Erik Faye-LundAug 5, 2011
  5. Pascal ObryAug 5, 2011
  6. Erik Faye-LundAug 5, 2011
  7. Erik Faye-LundAug 5, 2011
  8. Pascal ObryAug 5, 2011
  9. Ramsay JonesAug 9, 2011
  10. Ramsay JonesAug 9, 2011
  11. Junio C HamanoAug 5, 2011
  12. Erik Faye-LundAug 5, 2011
  13. Pascal ObryAug 6, 2011
  14. Ramsay JonesAug 9, 2011
  15. Pascal ObryAug 9, 2011
  16. Ramsay JonesAug 11, 2011
  17. Pascal ObryAug 13, 2011
  18. Vijay LakshminarayananAug 10, 2011
  19. Johannes SixtAug 9, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.