Re: [PATCH] checkout: do not corrupt HEAD on empty repo

From: Erik Faye-Lund <kusmabite@gmail.com>
Date: May 8, 2012, 16:35 UTC
Message-ID: <CABPQNSb-YPAa6qPtxeo1k-p-0REnk3soOTuPgABj9+s61o80VA@mail.gmail.com>
In-Reply-To: <7v4nrqy6ur.fsf@alter.siamese.dyndns.org>

On Tue, May 8, 2012 at 6:29 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Erik Faye-Lund <kusmabite@gmail.com> writes:
>
>> In abe1998 ("git checkout -b: allow switching out of an unborn
>> branch"), a code-path overly-optimisticly assumed that a
>> branch-name was specified. This is not always the case, and as
>> a result a NULL-pointer was attempted printed to .git/HEAD.
>>
>> This could lead to at least two different failure modes:
>>  1) The CRT formated the NULL-string as something useful (e.g
>>     "(null)")
>>  2) The CRT crasheed.
>
> Just a quick question.  What does a cathode ray tube have to do with this
> (or "are people expected to know what CRT you are talking about?")?
>

Feel free to change it to "the C runtime", or even "the vsnprintf implementation" if you feel like it :)