Re: [PATCH] checkout: do not corrupt HEAD on empty repo

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2012, 16:29 UTC
Message-ID: <7v4nrqy6ur.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1336493114-4984-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

Show 9 quoted lines

> In abe1998 ("git checkout -b: allow switching out of an unborn
> branch"), a code-path overly-optimisticly assumed that a
> branch-name was specified. This is not always the case, and as
> a result a NULL-pointer was attempted printed to .git/HEAD.
>
> This could lead to at least two different failure modes:
>  1) The CRT formated the NULL-string as something useful (e.g
>     "(null)")
>  2) The CRT crasheed.

Just a quick question. What does a cathode ray tube have to do with this (or "are people expected to know what CRT you are talking about?")?

Otherwise the explanation, the patch and the added test makes sense.

Thanks.