Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Oct 30, 2011, 23:57 UTC
- Message-ID
- <CABPQNSaLsS9P8hWMEBYVe4FEo5x11+J+pMw29NN+EF2siCO35w@mail.gmail.com>
- In-Reply-To
- <1319995124-7509-1-git-send-email-dejan.ribic@gmail.com>
Thanks for re-posting inline and with a sign-off. But there's still a few minor nits:
2011/10/30 Dejan Ribič <dejan.ribic@gmail.com>:
> "succeded" changed to "succeeded".
We write commit messages in imperative mood, so this should be something like 'change "succeded" to "succeeded"' instead. This is documented in Documentation/SubmittingPatches.
> modified: git-gui/lib/sshkey.tcl
We don't normally include a list of changed files in the commit message; the diffstat already provides that information.