git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Oct 30, 2011, 23:57 UTC
Message-ID
<CABPQNSaLsS9P8hWMEBYVe4FEo5x11+J+pMw29NN+EF2siCO35w@mail.gmail.com>
In-Reply-To
<1319995124-7509-1-git-send-email-dejan.ribic@gmail.com>

Thanks for re-posting inline and with a sign-off. But there's still a few minor nits:

2011/10/30 Dejan Ribič <dejan.ribic@gmail.com>:
> "succeded" changed to "succeeded".

We write commit messages in imperative mood, so this should be something like 'change "succeded" to "succeeded"' instead. This is documented in Documentation/SubmittingPatches.

> modified:   git-gui/lib/sshkey.tcl

We don't normally include a list of changed files in the commit message; the diffstat already provides that information.

Previous: Dejan RibičNext: Pat Thoyts
Message 2 of 8 in “Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.”
  1. Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.Dejan Ribič, Oct 30, 2011
  2. Erik Faye-LundOct 30, 2011
  3. Pat ThoytsOct 31, 2011
  4. 1/1 git-stash.txt: correct "git stash" behavior with no argumentsTakahito Ogawa, Oct 11, 2017
  5. 1/1 git-stash.txt: correct "git stash" behavior with no argumentsTakahito Ogawa, Oct 11, 2017
  6. Thomas GummererOct 11, 2017
  7. Thomas GummererOct 11, 2017
  8. 1/1 git-stash.txt: correct "git stash" behavior with no argumentsTakahito Ogawa, Oct 11, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.