Re: [PATCH 1/1] git-stash.txt: correct "git stash" behavior with no arguments

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Oct 11, 2017, 19:09 UTC
Message-ID: <20171011190935.GA15399@hank>
In-Reply-To: <20171011183718.2404-1-aiueogawa217@gmail.com>

On 10/12, Takahito Ogawa wrote:

Show 6 quoted lines

> "git stash" behavior without any arguments was changed in
> 1ada5020b ("stash: use stash_push for no verb form", 2017-02-28).
> This is equivalent to "git stash push" but documents says
> "git stash save".
> 
> Correct it.

Thanks for fixing this! I recently sent a patch that would advertise git stash push more in general, which would also fix this occurrence [1], but it didn't seem like it got much interest. However this is obviously correct, and should definitely be fixed, while the other places can still mention 'git stash save'.

For what it's worth this is

Reviewed-by: Thomas Gummerer <t.gummerer@gmail.com>

Show 21 quoted lines

> Signed-off-by: Takahito Ogawa <aiueogawa217@gmail.com>
> ---
>  Documentation/git-stash.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> index 00f95fee1..63642c145 100644
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.
>  The modifications stashed away by this command can be listed with
>  `git stash list`, inspected with `git stash show`, and restored
>  (potentially on top of a different commit) with `git stash apply`.
> -Calling `git stash` without any arguments is equivalent to `git stash save`.
> +Calling `git stash` without any arguments is equivalent to `git stash push`.
>  A stash is by default listed as "WIP on 'branchname' ...", but
>  you can give a more descriptive message on the command line when
>  you create one.
> -- 
> 2.13.1
>