git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/6] contrib/credential/osxkeychain/git-credential-osxkeychain.c: reduce scope of variables

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
Apr 16, 2014, 09:55 UTC
Message-ID
<CABPQNSa2dqzkKcaMycHQ9SUNL9tLvJGXPF4wPxv23NmFEnvrTQ@mail.gmail.com>
In-Reply-To
<1397640811-17719-4-git-send-email-gitter.spiros@gmail.com>
On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
Show 23 quoted lines
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  contrib/credential/osxkeychain/git-credential-osxkeychain.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> index bcd3f57..5ae09f6 100644
> --- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> +++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> @@ -163,12 +163,12 @@ static void read_credential(void)
>
>  int main(int argc, const char **argv)
>  {
> -       const char *usage =
> -               "usage: git credential-osxkeychain <get|store|erase>";
> -
>         if (!argv[1])
> +          {
> +              const char *usage =
> +                       "usage: git credential-osxkeychain <get|store|erase>";
>                 die(usage);
> -
> +          }
Again, not our code-style.
Previous: Elia PintoNext: Elia Pinto
Message 5 of 10 in “compat/regex/regcomp.c: reduce scope of variables”
  1. 1/6 compat/regex/regcomp.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  2. 2/6 compat/regex/regex_internal.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  3. 3/6 compat/regex/regexec.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  4. 4/6 contrib/credential/osxkeychain/git-credential-osxkeychain.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  5. Erik Faye-LundApr 16, 2014
  6. 5/6 contrib/credential/wincred/git-credential-wincred.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  7. Erik Faye-LundApr 16, 2014
  8. 6/6 xdiff/xprepare.c: reduce scope of variablesElia Pinto, Apr 16, 2014
  9. Erik Faye-LundApr 16, 2014
  10. Jonathan NiederApr 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.