From: Erik Faye-Lund <kusmabite@gmail.com>
Date: Wed, 16 Apr 2014 09:55:03 GMT
Subject: Re: [PATCH 4/6] contrib/credential/osxkeychain/git-credential-osxkeychain.c: reduce scope of variables
Message-ID: <CABPQNSa2dqzkKcaMycHQ9SUNL9tLvJGXPF4wPxv23NmFEnvrTQ@mail.gmail.com>
In-Reply-To: <1397640811-17719-4-git-send-email-gitter.spiros@gmail.com>

On Wed, Apr 16, 2014 at 11:33 AM, Elia Pinto <gitter.spiros@gmail.com> wrote:
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
>  contrib/credential/osxkeychain/git-credential-osxkeychain.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> index bcd3f57..5ae09f6 100644
> --- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> +++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
> @@ -163,12 +163,12 @@ static void read_credential(void)
>
>  int main(int argc, const char **argv)
>  {
> -       const char *usage =
> -               "usage: git credential-osxkeychain <get|store|erase>";
> -
>         if (!argv[1])
> +          {
> +              const char *usage =
> +                       "usage: git credential-osxkeychain <get|store|erase>";
>                 die(usage);
> -
> +          }

Again, not our code-style.