Re: [PATCH v2 1/3] add strnncmp() function
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Jun 17, 2014, 09:09 UTC
- Message-ID
- <CABPQNSZ7Vhn1Pz4j0R5twg+P-UzOG6xfw7fNqp0JO_Sh5t3CiA@mail.gmail.com>
- In-Reply-To
- <50de63f47ded2337adcd8bce151190fb99b38d64.1402990051.git.jmmahler@gmail.com>
On Tue, Jun 17, 2014 at 9:34 AM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
Show 29 quoted lines
> Add a strnncmp() function which behaves like strncmp() except it takes
> the length of both strings instead of just one. It behaves the same as
> strncmp() up to the minimum common length between the strings. When the
> strings are identical up to this minimum common length, the length
> difference is returned.
>
> Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
> ---
> strbuf.c | 9 +++++++++
> strbuf.h | 2 ++
> 2 files changed, 11 insertions(+)
>
> diff --git a/strbuf.c b/strbuf.c
> index ac62982..4eb7954 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -600,3 +600,12 @@ char *xstrdup_tolower(const char *string)
> result[i] = '\0';
> return result;
> }
> +
> +int strnncmp(const char *a, int len_a, const char *b, int len_b)
> +{
> + int min_len = (len_a < len_b) ? len_a : len_b;
> + int cmp = strncmp(a, b, min_len);
> + if (cmp)
> + return cmp;
> + return (len_a - len_b);
> +}Using a name that sounds like it's from the stdlib makes me cringe a little bit. Names that start with "str" reserved for stdlib[1][2], but we already ignore this for strbuf (and perhaps some other functions). However, in this case it doesn't seem *that* unlikely that we might collide with some stdlib-extensions.
[1]: http://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html#tag_02_02_02 [2]: http://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html