Re: [PATCH v2 0/3] add strnncmp() function

From: Jeremiah Mahler <jmmahler@gmail.com>
Date: Jun 17, 2014, 19:09 UTC
Message-ID: <20140617190912.GA23557@hudson.localdomain>
In-Reply-To: <20140617174817.GQ8557@google.com>

Jonathan,

On Tue, Jun 17, 2014 at 10:48:17AM -0700, Jonathan Nieder wrote:

Show 13 quoted lines

> >> On 2014-06-17 09.34, Jeremiah Mahler wrote:
> 
> >>> Also, strnncmp() was switched from using memcmp() to strncmp()
> >>> internally to make it clear that this is meant for strings, not
> >>> general buffers.
> 
> Why shouldn't I want to use this helper on arbitrary data?  One of the
> advantages of other helpers in git that take a pointer and a length
> (e.g., the strbuf library) are that they are 8-bit clean and can work
> on binary data when it's useful.
> 
> Thanks,
> Jonathan

Yes, along with the performance of strncmp() being worse than memcmp(), and Junios explanation of "counted strings", I think this was a bad idea. I will switch back to the memcmp() version.

-- 
Jeremiah Mahler
jmmahler@gmail.com
http://github.com/jmahler