Re: [PATCH/RFC] test-lib: add support for colors without tput
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Sep 14, 2012, 17:16 UTC
- Message-ID
- <CABPQNSYu1mAxn_ZKqgM6xcsgJfegu=upv0QQpFryMVrEH+KAsw@mail.gmail.com>
- In-Reply-To
- <CA+EOSBki2syrwdfzFXzBPuJAhH2jfgAbL=W+yP7bx8WXMkYiMQ@mail.gmail.com>
On Fri, Sep 14, 2012 at 7:12 PM, Elia Pinto <gitter.spiros@gmail.com> wrote:
Show 20 quoted lines
> 2012/9/14 Elia Pinto <gitter.spiros@gmail.com>: >> 2012/9/14 Erik Faye-Lund <kusmabite@gmail.com>: >>> On Fri, Sep 14, 2012 at 6:54 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote: >>>> On Fri, Sep 14, 2012 at 6:41 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote: >>>>> diff --git a/t/test-lib.sh b/t/test-lib.sh >>>>> index 78c4286..7d1b34b 100644 >>>>> --- a/t/test-lib.sh >>>>> +++ b/t/test-lib.sh >>>>> @@ -129,6 +129,20 @@ export _x05 _x40 _z40 LF >>>>> # This test checks if command xyzzy does the right thing... >>>>> # ' >>>>> # . ./test-lib.sh >>>>> + >> Nice. But this setting should be check that we have a terminal first isn't ? >> Some test like this before >> >> test "X$$TERM" != Xdumb \ >> && test -t 1 2>/dev/null \ >> && .... > and in reality this echo use is not portable.
Yeah; I posted a couple of follow-up mails earlier where I had noticed it and changed to printf instead. It seems the testsuite is already using it, so it's probably portable.
Thanks a lot for the extra set of eyes :)
-- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en