git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] test-lib: add support for colors without tput

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 17, 2012, 17:39 UTC
Message-ID
<50576058.4020508@kdbg.org>
In-Reply-To
<50536943.4030300@kdbg.org>
Am 14.09.2012 19:28, schrieb Johannes Sixt:
Show 22 quoted lines
> Am 14.09.2012 18:58, schrieb Erik Faye-Lund:
>>  	tput () {
>>  		case "$1" in
>>  		bold)
>> -			echo -ne "\033[1m" ;;
>> +			printf "\033[1m" ;;
>>  		setaf)
>> -			echo -ne "\033[0;3$2m" ;;
>> +			printf "\033[0;3$2m" ;;
> 
> This should be
> 			printf '\033[0;3%sm' "$2" ;;
> 
>>  		sgr0)
>> -			echo -ne "\033(\033[m" ;;
>> +			printf "\033(\033[m" ;;
>>  		esac
>>  	}
>>  fi
> 
> Did you test this only in rxvt or in CMD as well? (I hadn't time to
> test, yet, so I'm asking :-)
I tested your patch with this fixup, and it works for me (in CMD).
-- Hannes
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
Previous: Johannes SixtNext: Junio C Hamano
Message 12 of 17 in “test-lib: add support for colors without tput”
  1. test-lib: add support for colors without tputErik Faye-Lund, Sep 14, 2012
  2. Erik Faye-LundSep 14, 2012
  3. Erik Faye-LundSep 14, 2012
  4. Elia PintoSep 14, 2012
  5. Erik Faye-LundSep 14, 2012
  6. Elia PintoSep 14, 2012
  7. Erik Faye-LundSep 14, 2012
  8. Johannes SixtSep 14, 2012
  9. Erik Faye-LundSep 14, 2012
  10. Erik Faye-LundSep 14, 2012
  11. Johannes SixtSep 14, 2012
  12. Johannes SixtSep 17, 2012
  13. Junio C HamanoSep 14, 2012
  14. Erik Faye-LundSep 14, 2012
  15. Junio C HamanoSep 14, 2012
  16. Jeff KingSep 14, 2012
  17. Erik Faye-LundSep 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.