Re: [PATCH v2] help.c: fix autocorrect in work tree for bare repository

From: Simon Gerber <gesimu@gmail.com>
Date: Dec 13, 2022, 09:48 UTC
Message-ID: <CAAyHH3239rmRR5mhy-cS7XFVuXi2AnYG5nQkFcpKMd4WTfmoBg@mail.gmail.com>
In-Reply-To: <xmqqa63sqe1b.fsf@gitster.g>

On Tue, 13 Dec 2022 at 02:37, Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

>
> "Simon Gerber via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > --- a/t/t9003-help-autocorrect.sh
> > +++ b/t/t9003-help-autocorrect.sh
> > @@ -60,4 +60,10 @@ test_expect_success 'autocorrect can be declined altogether' '
> >       test_line_count = 1 actual
> >  '
> >
> > +test_expect_success 'autocorrect works in work tree created from bare repo' '
> > +     git clone --bare . bare.git &&
> > +     git -C bare.git worktree add ../worktree &&
> > +     git -C worktree -c help.autocorrect=immediate stauts
>
> The reason why this third line is a sufficient test is...?
>
> If "status" is invoked successfully, it would not exit with non-zero
> status as long as it correctly notices that it was invoked in a
> worktree (as opposed to the current code without your fix, which
> would say "nah, where you are running there is no worktree", that is
> incorrect), but one scenario I am a bit worried about is what if the
> tester has an entry on $PATH that has "git-static" or whatever that
> is similar enough to "status", to cause autocorrect work differently
> from the case where "git status" would be the only plausible case.

Thanks for pointing out that autocorrect could work differently for a tester depending on what's in their path. I didn't consider that case at all.

>
> But then we can tell such a tester "don't do that, then" ;-)

I think that's fine in this case.

>
> Let's queue the patch as-is and see what others think.

Awesome, thanks

Show 7 quoted lines

>
> Thanks.
>
> > +'
> > +
> >  test_done
>