Re: [PATCH v2] help.c: fix autocorrect in work tree for bare repository

From: Simon Gerber <gesimu@gmail.com>
Date: Dec 12, 2022, 16:38 UTC
Message-ID: <CAAyHH30eoRAgtO+QOZZFbx89Nr55xtndu6pRa5k=ZnJZXnZACw@mail.gmail.com>
In-Reply-To: <pull.1373.v2.git.git.1667073374852.gitgitgadget@gmail.com>

On Sat, 29 Oct 2022 at 21:56, Simon Gerber via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 20 quoted lines

>
> [commit message omitted]
> ---
>     Fix autocorrect in work tree for bare repository
>
>     Currently, auto correction doesn't work reliably for commands which must
>     run in a work tree (e.g. git status) in Git work trees which are created
>     from a bare repository.
>
>     This patch adds a test case illustrating the issue and proposes a fix
>     which adjusts the usage of read_early_config() in help_unknown_cmd() to
>     match other usages of read_early_config(). In particular the patch
>     removes the call to git_default_config() in the read config callback.
>
>     Changes since v1 (both suggested by Junio):
>
>      * Moved test to 9003
>      * Squashed change and test into a single commit
>
> [diff omitted]

Hi all,

Just wanted to check what the state on this patch is (side-note: I just noticed that I didn't cc Junio in the v2 submission, my apologies). As described in the quote (and the parent email), the patch fixes how auto correct initializes the config. Version 2 addresses the points raised on v1, in particular, I've moved the test to 9003, and have squashed the change into a single commit. Please let me know if further changes are necessary.

-- Simon