git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gpg-interface: still print ssh signatures when allowed signers file is not set

From
GTGrayson Tinker <graysontinker@gmail.com>
Date
Jul 10, 2026, 03:42 UTC
Message-ID
<CAAr3fC29Mkn08B4-TWF9Vuhng0TcjV+mRGFa9DjkxgKixB_hXQ@mail.gmail.com>
In-Reply-To
<xmqqtsq7haev.fsf@gitster.g>
On Thu, Jul 9, 2026 at 6:59 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> If a user runs 'git log --show-signature -100', they will be spammed
> with this message 100 times.  Because it bypasses the
> advise_if_enabled() mechanism, there is no way for them to disable
> it.

The downside to using advise_if_enabled is that this single line would get turned into three, with a newline in the middle, which would decently disrupt the view of the log until the hint is disabled. I'm not sure what the best solution is here; I lean towards keeping it as is to reduce the overall noise level, but perhaps those who use this feature more would disagree.

(The previous message was also printed every time, FWIW. So at the very least this isn't worse behavior.)

I'll make the hint disableable if you'd prefer.
Show 7 quoted lines
> However, doesn't cryptographic verification still provide value on
> its own?  Even without allowedSignersFile, the signature at least
> guarantees the commit content hasn't been modified since it was
> signed, even if the signer's identity remains unverified.  If some
> users rely on this purely cryptographic validation, they probably
> won't want to maintain an allowed signers file, and they would
> definitely want a way to squelch this repetitive advice.

Allowing for this usecase was exactly the intent of this patch; I am this type of user and had some annoyance with this.

Thanks!
Previous: Junio C Hamano
Message 4 of 4 in “gpg-interface: still print ssh signatures when allowed signers file is not set”
  1. gpg-interface: still print ssh signatures when allowed signers file is not setGrayson Tinker, Jun 25, 2026
  2. Grayson TinkerJul 9, 2026
  3. Junio C HamanoJul 10, 2026
  4. Grayson TinkerJul 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.