From: Grayson Tinker Date: Fri, 10 Jul 2026 03:42:59 GMT Subject: Re: [PATCH] gpg-interface: still print ssh signatures when allowed signers file is not set Message-ID: In-Reply-To: On Thu, Jul 9, 2026 at 6:59 PM Junio C Hamano wrote: > > If a user runs 'git log --show-signature -100', they will be spammed > with this message 100 times. Because it bypasses the > advise_if_enabled() mechanism, there is no way for them to disable > it. The downside to using advise_if_enabled is that this single line would get turned into three, with a newline in the middle, which would decently disrupt the view of the log until the hint is disabled. I'm not sure what the best solution is here; I lean towards keeping it as is to reduce the overall noise level, but perhaps those who use this feature more would disagree. (The previous message was also printed every time, FWIW. So at the very least this isn't worse behavior.) I'll make the hint disableable if you'd prefer. > However, doesn't cryptographic verification still provide value on > its own? Even without allowedSignersFile, the signature at least > guarantees the commit content hasn't been modified since it was > signed, even if the signer's identity remains unverified. If some > users rely on this purely cryptographic validation, they probably > won't want to maintain an allowed signers file, and they would > definitely want a way to squelch this repetitive advice. Allowing for this usecase was exactly the intent of this patch; I am this type of user and had some annoyance with this. Thanks!