Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path
- From
Pat Pannuto <pat.pannuto@gmail.com>
- Date
- Jan 12, 2017, 21:01 UTC
- Message-ID
- <CAAnLKaGvz4Wzs36gMSdoYCg+tzx6KFCe59FNnk5zNQ-L58ww1g@mail.gmail.com>
- In-Reply-To
- <xmqqbmvcj9le.fsf@gitster.mtv.corp.google.com>
I'm happy to let this drop.
I've filed the missing perl library as a homebrew issue [1], so hopefully this won't be an issue for folks in the future.
You may still want the 1/2 patch in this series, just to make things internally consistent with "-w" vs "use warnings;" inside git's perl scripts.
-Pat
[1] https://github.com/Homebrew/homebrew-core/issues/8783
On Thu, Jan 12, 2017 at 3:40 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > >> So if this patch would make it into upstream Git, I would *have* to revert >> it in Git for Windows, adding to my already considerable maintenance burden. > > I do not think we want "#!/usr/bin/env $language" in the upstream, > either. >