Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 12, 2017, 06:27 UTC
- Message-ID
- <6fe462dd-929a-671b-a210-36ee38e99115@kdbg.org>
- In-Reply-To
- <20170112055140.29877-3-pat.pannuto@gmail.com>
Am 12.01.2017 um 06:51 schrieb Pat Pannuto:
Show 7 quoted lines
> diff --git a/git-add--interactive.perl b/git-add--interactive.perl > index cf6fc926a..6d7b6c35d 100755 > --- a/git-add--interactive.perl > +++ b/git-add--interactive.perl > @@ -1,4 +1,4 @@ > -#!/usr/bin/perl > +#!/usr/bin/env perl
This change, and all others that affect installed external git programs, is a no-go. On Windows, our execve emulation is not complete. It would invoke only `env` (looked up in PATH), but not pass 'perl' as argument.
Sorry for the bad news.
I would have suggested to set PERL_PATH in your config.mak, but that does not change the generated perl scripts, I think. Perhaps you should implement that?
I'm not thrilled about your changes to the test scripts, but I do not expect that they break on Windows.
-- Hannes