git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit

From
Mugdha Pattnaik <mugdhapattnaik@gmail.com>
Date
Oct 6, 2021, 11:45 UTC
Message-ID
<CAA4dvxgXNPDRB6okD8bdS_Tu=EEgr5pphxK1u4QCJjJYb=TaMw@mail.gmail.com>
In-Reply-To
<87sfxpvxcs.fsf@evledraar.gmail.com>
On Tue, Sep 28, 2021 Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> shouldn't the post-image "! test -d" just be a test_path_is_missing?
> I.e. should this pass if .git is a file? Probably not...

I agree, this test should not pass if .git is a file. I'll change it to "test_path_is_missing" and send an update to the patch.

Previous: Ævar Arnfjörð BjarmasonNext: Mugdha Pattnaik via GitGitGadget
Message 9 of 18 in “submodule: absorb git dir instead of dying on deinit”
  1. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Aug 26, 2021
  2. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Aug 27, 2021
  3. Atharva RaykarAug 27, 2021
  4. Junio C HamanoAug 27, 2021
  5. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Aug 27, 2021
  6. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Aug 27, 2021
  7. Christian CouderSep 28, 2021
  8. Ævar Arnfjörð BjarmasonSep 28, 2021
  9. Mugdha PattnaikOct 6, 2021
  10. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Oct 6, 2021
  11. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Oct 6, 2021
  12. Junio C HamanoOct 7, 2021
  13. Mugdha PattnaikNov 16, 2021
  14. Junio C HamanoNov 16, 2021
  15. Mugdha PattnaikNov 17, 2021
  16. submodule: absorb git dir instead of dying on deinitMugdha Pattnaik via GitGitGadget, Nov 19, 2021
  17. Bagas SanjayaAug 27, 2021
  18. Mugdha PattnaikAug 27, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.