From: Mugdha Pattnaik Date: Wed, 06 Oct 2021 11:45:26 GMT Subject: Re: [PATCH v4] submodule: absorb git dir instead of dying on deinit Message-ID: In-Reply-To: <87sfxpvxcs.fsf@evledraar.gmail.com> On Tue, Sep 28, 2021 Ævar Arnfjörð Bjarmason wrote: > shouldn't the post-image "! test -d" just be a test_path_is_missing? > I.e. should this pass if .git is a file? Probably not... I agree, this test should not pass if .git is a file. I'll change it to "test_path_is_missing" and send an update to the patch.