git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make pull.c match the structural conventions

From
JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com>
Date
Dec 12, 2025, 14:48 UTC
Message-ID
<CA+rGoLeO1P9DLNVgiQJ0=nAQEgt=W+jgKM6XZ9TSipMdPxAjNA@mail.gmail.com>
In-Reply-To
<52483794-bdba-44b8-9222-761184ecea95@app.fastmail.com>
>
> I’ve seen some commit messages in the last few months that have too many
> adjectives. I’ve never seen that style before.
>

Ahh, well I had this format saved from Junio --- First line should be an order (Not added but add) and then give a line empty space.

Then
- Give an observation on how the current system works in the
   present tense (so no need to say "Currently X is Y", or
   "Previously X was Y" to describe the state before your change;
   just "X is Y" is enough), and discuss what you perceive as a
   problem in it.
 - Propose a solution (optional---often, problem description
   trivially leads to an obvious solution in reader's minds).
 - Give commands to the codebase to "become like so".
---

I tried to force this format here too That caused a lot of adjective issues. The patch above is just a copy and a paste and I get why the commit message felt the way it did.

Thank you
- Jayatheerth
Previous: Kristoffer Haugsbakk
Message 5 of 5 in “Make pull.c match the structural conventions”
  1. Make pull.c match the structural conventionsK Jayatheerth, Dec 12, 2025
  2. Junio C HamanoDec 12, 2025
  3. pull: move options[] array into function scopeK Jayatheerth, Dec 12, 2025
  4. Kristoffer HaugsbakkDec 12, 2025
  5. JAYATHEERTH KDec 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.