From: JAYATHEERTH K Date: Fri, 12 Dec 2025 14:48:45 GMT Subject: Re: [PATCH] Make pull.c match the structural conventions Message-ID: In-Reply-To: <52483794-bdba-44b8-9222-761184ecea95@app.fastmail.com> > > I’ve seen some commit messages in the last few months that have too many > adjectives. I’ve never seen that style before. > Ahh, well I had this format saved from Junio --- First line should be an order (Not added but add) and then give a line empty space. Then - Give an observation on how the current system works in the present tense (so no need to say "Currently X is Y", or "Previously X was Y" to describe the state before your change; just "X is Y" is enough), and discuss what you perceive as a problem in it. - Propose a solution (optional---often, problem description trivially leads to an obvious solution in reader's minds). - Give commands to the codebase to "become like so". --- I tried to force this format here too That caused a lot of adjective issues. The patch above is just a copy and a paste and I get why the commit message felt the way it did. Thank you - Jayatheerth