git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refspec: make @ a valid refspec

From
Jacob Keller <jacob.keller@gmail.com>
Date
Nov 24, 2020, 22:52 UTC
Message-ID
<CA+P7+xr8_s0Fq_TGjDjHEPpGJ8Br5x7omY1fsg0HjcXjutyRkg@mail.gmail.com>
In-Reply-To
<xmqqo8jmgyrd.fsf@gitster.c.googlers.com>
On Tue, Nov 24, 2020 at 2:45 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
>
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> >> I too find that "@ is a shortcut for HEAD" looks ugly both at the UI
> >> level and at the implementation level [*1*], but as long as we have
> >> it, it is good to try to be consistent and allow "@" everywhere
> >> where one would write "HEAD" in places where it is syntacitically
> >> infeasible---at least we would be consistently ugly that way ;-).
> >
> > Beauty is in the eye of the beholder.
>
> Using "@" is rather "illogical" than "ugly", and at that point it is
> not so subjective.
>
> @-mark leads a suffix that applies some "magic" to what comes before
> it (e.g. next@{1}, maint@{2.weeks.ago}, and master@{-1}).  Making @
> a synonym for HEAD means '@' sometimes means a ref and most of the
> time means the introducer of magic that applies to a ref.
>
> Worse yet, @{4} does not refer to HEAD@{4} but refers to the 4-th
> previous commit the current branch pointed at, so a mnemonic for the
> end user to remember the distinction between the two is that a bare
> "@" is different from HEAD, which is a total opposite X-<.
>

However, @{0} *does* refer to what is currently checked out, which would be head.. So in a sense @ meaning "the current branch" and applying @{0} would always be HEAD, no?

I think it sort of works, but yea it is a bit messy.

Thanks, Jake

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 13 in “refspec: make @ a valid refspec”
  1. refspec: make @ a valid refspecFelipe Contreras, Nov 22, 2020
  2. Jeff KingNov 24, 2020
  3. Junio C HamanoNov 24, 2020
  4. Felipe ContrerasNov 24, 2020
  5. Junio C HamanoNov 24, 2020
  6. Jacob KellerNov 24, 2020
  7. Junio C HamanoNov 24, 2020
  8. Jacob KellerNov 24, 2020
  9. Felipe ContrerasNov 25, 2020
  10. Junio C HamanoNov 25, 2020
  11. Felipe ContrerasNov 25, 2020
  12. Felipe ContrerasNov 25, 2020
  13. Felipe ContrerasDec 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.