git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] describe: bail of --contains --all is used with --exclude or --match

From
Jacob Keller <jacob.keller@gmail.com>
Date
May 28, 2026, 00:43 UTC
Message-ID
<CA+P7+xr0tP6Ft3qPwbkxNRgNB2a24_WFC+8DymFnm11Ks=sf5g@mail.gmail.com>
In-Reply-To
<20260519083559.onq6r%taahol@utu.fi>
On Tue, May 19, 2026 at 1:36 AM Tuomas Ahola <taahol@utu.fi> wrote:
Show 36 quoted lines
>
> Jacob Keller <jacob.e.keller@intel.com> wrote:
>
> > From: Jacob Keller <jacob.keller@gmail.com>
> >
> > If you try to use git describe --contains with --all, the exclude and
> > match patterns are silently ignored.
> >
> > This results in unexpected behavior, as you may try to provide patterns
> > and expect it to change the result.
> >
>
> I got just bitten by that, and yes, it was quite unexpected.
>
> > Check for this, and have describe die when it encounters this, instead
> > of silently ignoring the provided options.
> >
> > Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> > ---
> >
> > I just found this while trying to use it, the patterns weren't being applied
> > properly.
> >
> > This is pretty quick/dirty, I haven't had time to write a test, or anything.
> >
>
> Would you like to resurrect the patch?  It seems it was never merged,
> nor the underlying problem fixed:
>
> ```
> $ git describe --contains --all --match=bogus
> master
> $ git describe --contains --all --exclude="*"
> master
> ```
>
Apologies for a delayed response. I'll try to look into reviving this tomorrow.
Previous: Tuomas Ahola
Message 4 of 4 in “describe: bail of --contains --all is used with --exclude or --match”
  1. describe: bail of --contains --all is used with --exclude or --matchJacob Keller, Feb 26, 2019
  2. Eric SunshineFeb 26, 2019
  3. Tuomas AholaMay 19, 2026
  4. Jacob KellerMay 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.