From: Jacob Keller Date: Thu, 28 May 2026 00:43:32 GMT Subject: Re: [PATCH] describe: bail of --contains --all is used with --exclude or --match Message-ID: In-Reply-To: <20260519083559.onq6r%taahol@utu.fi> On Tue, May 19, 2026 at 1:36 AM Tuomas Ahola wrote: > > Jacob Keller wrote: > > > From: Jacob Keller > > > > If you try to use git describe --contains with --all, the exclude and > > match patterns are silently ignored. > > > > This results in unexpected behavior, as you may try to provide patterns > > and expect it to change the result. > > > > I got just bitten by that, and yes, it was quite unexpected. > > > Check for this, and have describe die when it encounters this, instead > > of silently ignoring the provided options. > > > > Signed-off-by: Jacob Keller > > --- > > > > I just found this while trying to use it, the patterns weren't being applied > > properly. > > > > This is pretty quick/dirty, I haven't had time to write a test, or anything. > > > > Would you like to resurrect the patch? It seems it was never merged, > nor the underlying problem fixed: > > ``` > $ git describe --contains --all --match=bogus > master > $ git describe --contains --all --exclude="*" > master > ``` > Apologies for a delayed response. I'll try to look into reviving this tomorrow.