Re: [RFC/PATCH 0/2] Color moved code differently

From: Jacob Keller <jacob.keller@gmail.com>
Date: Sep 4, 2016, 09:57 UTC
Message-ID: <CA+P7+xp=s4uOvqTS0wuduE0WmxOsWo_EYT5zW0U_2gfcHT7mGg@mail.gmail.com>
In-Reply-To: <20160903033120.20511-1-sbeller@google.com>

On Fri, Sep 2, 2016 at 8:31 PM, Stefan Beller <sbeller@google.com> wrote:

Show 15 quoted lines

> When moving code (e.g. a function is moved to another part of the file or
> to a different file), the review process is different than reviewing new
> code. When reviewing moved code we are only interested in the diff as
> where there are differences in the moved code, e.g. namespace changes.
>
> However the inner part of these moved texts should not change.
> To aid a developer reviewing such code, we'll color pure moved stuff
> differently.
>
> A line is colored differently if that line and the surroundign 2 lines
> appear as-is in the opposite part of the diff.
>
> Example:
> http://i.imgur.com/ay84q0q.png
>

In the example, the first and last lines of duplicate copies don't get colored differently, and that threw me off. I feel like that was maybe not intentional? If it was, can you explain why?

Thanks, Jake