[RFC/PATCH 0/2] Color moved code differently
- From
Stefan Beller <sbeller@google.com>
- Date
- Sep 3, 2016, 03:31 UTC
- Message-ID
- <20160903033120.20511-1-sbeller@google.com>
When moving code (e.g. a function is moved to another part of the file or to a different file), the review process is different than reviewing new code. When reviewing moved code we are only interested in the diff as where there are differences in the moved code, e.g. namespace changes.
However the inner part of these moved texts should not change. To aid a developer reviewing such code, we'll color pure moved stuff differently.
A line is colored differently if that line and the surroundign 2 lines appear as-is in the opposite part of the diff.
Example: http://i.imgur.com/ay84q0q.png
Or apply these patches and
git show e28eae3184b26d3cf3293e69403babb5c575342c
git show bc9204d4ef6e0672389fdfb0d398fa9a39dba3d5
git show 8465541e8ce8eaf16e66ab847086779768c18f2dThe code quality sucks though, hence RFC.
Thanks, Stefan
Stefan Beller (2): diff.c: emit duplicate lines with a different color WIP xdiff: markup duplicates differently
diff.c | 26 ++++++++++++ diff.h | 4 +- xdiff/xdiff.h | 1 + xdiff/xemit.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 156 insertions(+), 3 deletions(-)
-- 2.10.0.rc2.23.gf336a1a.dirty