Re: [PATCH 3/5] submodule: export sanitized GIT_CONFIG_PARAMETERS

From: Jacob Keller <jacob.keller@gmail.com>
Date: Apr 28, 2016, 15:40 UTC
Message-ID: <CA+P7+xoiyEdKQhcb7QAQOqr2ynhmyNtg3_+Jdi3s6vsfVHMo3w@mail.gmail.com>
In-Reply-To: <20160428153601.GD31063@sigill.intra.peff.net>

On Thu, Apr 28, 2016 at 8:36 AM, Jeff King <peff@peff.net> wrote:

Show 32 quoted lines

> On Thu, Apr 28, 2016 at 08:28:29AM -0700, Jacob Keller wrote:
>
>> > diff --git a/git-submodule.sh b/git-submodule.sh
>> > index 2a84d7e..3a40d4b 100755
>> > --- a/git-submodule.sh
>> > +++ b/git-submodule.sh
>> > @@ -200,6 +200,7 @@ sanitize_submodule_env()
>> >         sanitized_config=$(git submodule--helper sanitize-config)
>> >         clear_local_git_env
>> >         GIT_CONFIG_PARAMETERS=$sanitized_config
>> > +       export GIT_CONFIG_PARAMETERS
>>
>> why not
>>
>> export GIT_CONFIG_PARAMETERS=$santized_config
>
> Portability. Try:
>
>   $ dash -c 'one="foo bar"; export two=$one; echo $two'
>   foo
>
>   $ bash -c 'one="foo bar"; export two=$one; echo $two'
>   foo bar
>
> I think:
>
>   export GIT_CONFIG_PARAMETERS="$sanitized_config"
>
> solves that. Some antique shells do not like "export x=y" at all, but I
> don't know if any of them are still relevant.
>
> -Peff

Fair enough. quotes would most likely work and I know I am in the habbit of using quotes a bit more liberally but this will work correctly so I wouldn't change it.

Thanks, Jake