Re: [PATCH 1/5] t5550: fix typo in $HTTPD_URL

From: Jeff King <peff@peff.net>
Date: Apr 28, 2016, 15:25 UTC
Message-ID: <20160428152549.GB31063@sigill.intra.peff.net>
In-Reply-To: <CA+P7+xqSYA5++pq0_0FYFg8TXhc7f0=X_4uNWtFRpebEDzqtHQ@mail.gmail.com>

On Thu, Apr 28, 2016 at 08:24:05AM -0700, Jacob Keller wrote:

Show 10 quoted lines

> On Thu, Apr 28, 2016 at 6:36 AM, Jeff King <peff@peff.net> wrote:
> > Commit 14111fc (git: submodule honor -c credential.* from
> > command line, 2016-02-29) accidentally wrote $HTTP_URL. It
> > happened to work because we ended up with "credential..helper",
> > which we treat the same as "credential.helper", applying it
> > to all URLs.
> 
> You say "credential.helper" twice here? I think that's confusing. The
> patch looks perfectly fine but I am having trouble parsing this
> description. 'We end up with X which we treat the same as X"?

Note the two dots in the first one. There is no variable $HTTP_URL, so:

  credential.$HTTP_URL.helper

becomes:

  credential..helper

-Peff