git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] notes: add notes.merge option to select default strategy

From
Jacob Keller <jacob.keller@gmail.com>
Date
Aug 2, 2015, 08:20 UTC
Message-ID
<CA+P7+xoLpedQMiOg3V9m5S-0OShPpAnDS6_qb62E2c8A-if1Nw@mail.gmail.com>
In-Reply-To
<20150802080123.GA17440@flurp.local>
On Sun, Aug 2, 2015 at 1:01 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 10 quoted lines
> Don't worry too much about it. Consider it something to keep in mind for
> future patches. I reviewed the change and it seemed okay. I mentioned it
> because one of the goals of patch submission, in addition to making an
> actual change, is to ease the review process. If Junio is okay with
> accepting it as is, then it's probably not worth spending more time
> trying to refine it.
>
> Having said that, I came up with the following for those two paragraphs,
> which gives a much less noisy diff and doesn't look too jagged:
>

Yea, I actually have re-worked it as well to something more suitable. I'm re-sending anyways as I fixed some of the other style issues and the one bug about not returning 0 on good read of the notes.merge value.

Regards Jake

Previous: Eric SunshineNext: Johan Herland
Message 8 of 9 in “notes: add notes.merge strategy option”
  1. 0/2 notes: add notes.merge strategy optionJacob Keller, Jul 31, 2015
  2. 1/2 notes: document cat_sort_uniq rewriteModeJacob Keller, Jul 31, 2015
  3. 2/2 notes: add notes.merge option to select default strategyJacob Keller, Jul 31, 2015
  4. Eric SunshineAug 2, 2015
  5. Jacob KellerAug 2, 2015
  6. Jacob KellerAug 2, 2015
  7. Eric SunshineAug 2, 2015
  8. Jacob KellerAug 2, 2015
  9. Johan HerlandAug 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.