From: Jacob Keller <jacob.keller@gmail.com>
Date: Sun, 02 Aug 2015 08:20:32 GMT
Subject: Re: [PATCH v2 2/2] notes: add notes.merge option to select default strategy
Message-ID: <CA+P7+xoLpedQMiOg3V9m5S-0OShPpAnDS6_qb62E2c8A-if1Nw@mail.gmail.com>
In-Reply-To: <20150802080123.GA17440@flurp.local>

On Sun, Aug 2, 2015 at 1:01 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> Don't worry too much about it. Consider it something to keep in mind for
> future patches. I reviewed the change and it seemed okay. I mentioned it
> because one of the goals of patch submission, in addition to making an
> actual change, is to ease the review process. If Junio is okay with
> accepting it as is, then it's probably not worth spending more time
> trying to refine it.
>
> Having said that, I came up with the following for those two paragraphs,
> which gives a much less noisy diff and doesn't look too jagged:
>

Yea, I actually have re-worked it as well to something more suitable.
I'm re-sending anyways as I fixed some of the other style issues and
the one bug about not returning 0 on good read of the notes.merge
value.

Regards
Jake