Re: [PATCH 4/5] revision.c: refactor ref selection handler after --exclude

From: Jacob Keller <jacob.keller@gmail.com>
Date: Jan 25, 2017, 17:41 UTC
Message-ID: <CA+P7+xoL28hTdjbPfau_cgui3j73pMJqOBsM+5-kKSA369yJ1Q@mail.gmail.com>
In-Reply-To: <20170125125054.7422-5-pclouds@gmail.com>

On Wed, Jan 25, 2017 at 4:50 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 16 quoted lines

> Behavior change: "--exclude --blah --remotes" will not exclude remote
> branches any more. Only "--exclude --remotes" does.
>
> This is because --exclude is going to have a new friend --decorate-reflog
> who haves the same way. When you allow a distant --remotes to complement
> a previous option, things get complicated. In
>
>     --exclude .. --decorate-reflog ... --remotes
>
> Does it mean decorate remote reflogs, or does it mean exclude remotes
> from the selected revisions?
>
> Granted, there may be valid use cases for such a combination (e.g.
> "decorate all reflogs except remote ones") but I feel option order is
> not a good fit to express them.
>

Limiting the scope of the exclude seems somewhat reasonable to me, because it makes it much easier to explain and show the user. We do need to make sure it's not going to break any scripts or other issues. Is it possible for us to produce an error if the user does "--exclude" without a necessary connecting option?

Thanks, Jake