Re: [PATCH] log: new option decorate reflog of remote refs

From: Jeff King <peff@peff.net>
Date: Jan 21, 2017, 14:08 UTC
Message-ID: <20170121140806.tjs6wad3x4srdv3q@sigill.intra.peff.net>
In-Reply-To: <CACsJy8C41D0Qb0ZJoAPJ6Pwp904dVixUR9yXQmZr0NU9W-BU8A@mail.gmail.com>

On Sat, Jan 21, 2017 at 07:48:50PM +0700, Duy Nguyen wrote:

Show 5 quoted lines

> OK. Next question, how do we deal with the reflog count (i..e the
> argument of --decorate-remote-reflog). Should it be shared for all ref
> type, or can be specified differently for remote, local and tags? I'm
> leaning towards the former. But I'll wait a bit for ideas before
> rewriting the patch.

I doubt that anybody really cares about different reflog depths for different refs. But I would say that the natural syntax ends up as:

  git log --decorate-reflog=10 --remotes \
          --decorate-reflog=10 --tags

anyway, so you get the ability to do it anyway "for free" (at the cost of having to repeat yourself).

I guess the other option is:

  git log --decorate-reflog-depth=10 \
          --decorate-reflog --remotes
	  --decorate-reflog --tags

That's actually _more_ typing, and besides being less flexible just muddles the "is this option for the next ref-selector or not" question.

(The whole thing is obviously a lot of typing; I wonder if people would want a config option to do this all the time).

-Peff