git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/8] Better heuristics make prettier diffs

From
Jacob Keller <jacob.keller@gmail.com>
Date
Sep 7, 2016, 21:21 UTC
Message-ID
<CA+P7+xo7Q0q+Vg4atb23M90HiMazwgiXGFmgty-+hF-r+3veww@mail.gmail.com>
In-Reply-To
<xmqqy433mvg6.fsf@gitster.mtv.corp.google.com>
On Wed, Sep 7, 2016 at 11:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Michael Haggerty <mhagger@alum.mit.edu> writes:
>
>> * In "blame: honor the diff heuristic options and config":
>>
>>   * In v2, I suggested making `blame` honor all diff-related options.
>>     Junio explained why this was a bad idea. So this version only
>>     makes `blame` honor `--indent-heuristic` and
>>     `--compaction-heuristic`.
>
> This makes a lot more sense to me.  I am not sure if it is worth
> adding 7/8 to expose these experimental knobs to the end users, but
> the amount of the code needed is very small, so let's take it.
>
> I am hoping that we can lose both of the experimental knobs and use
> the indent heuristic unconditionally in the future, though ;-)
>
> Thanks.
>

Agreed, I think we should drop the knobs and use the feature unconditionally as well.

Thanks, Jake

Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 16 in “Better heuristics make prettier diffs”
  1. 0/8 Better heuristics make prettier diffsMichael Haggerty, Sep 5, 2016
  2. 1/8 xdl_change_compact(): fix compaction heuristic to adjust ixoMichael Haggerty, Sep 5, 2016
  3. 7/8 parse-options: add parse_opt_unknown_cb()Michael Haggerty, Sep 5, 2016
  4. 3/8 is_blank_line(): take a single xrecord_t as argumentMichael Haggerty, Sep 5, 2016
  5. 2/8 xdl_change_compact(): only use heuristic if group can't be matchedMichael Haggerty, Sep 5, 2016
  6. 5/8 xdl_change_compact(): introduce the concept of a change groupMichael Haggerty, Sep 5, 2016
  7. 8/8 blame: honor the diff heuristic options and configMichael Haggerty, Sep 5, 2016
  8. 6/8 diff: improve positioning of add/delete blocks in diffsMichael Haggerty, Sep 5, 2016
  9. 4/8 recs_match(): take two xrecord_t pointers as argumentsMichael Haggerty, Sep 5, 2016
  10. Junio C HamanoSep 7, 2016
  11. Jacob KellerSep 7, 2016
  12. Junio C HamanoSep 7, 2016
  13. Michael HaggertySep 19, 2016
  14. Junio C HamanoSep 19, 2016
  15. Junio C HamanoSep 19, 2016
  16. Michael HaggertySep 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.