git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-backend: remove a duplicated code branch

From
Robin Dupret <robin.dupret@gmail.com>
Date
Oct 26, 2021, 19:04 UTC
Message-ID
<CA+G124Xci1bGG1uxt35gr9ede11ix10CtLmmWcT+eYNCDSN6Xw@mail.gmail.com>
In-Reply-To
<xmqqsfwp2j6o.fsf@gitster.g>
> Did you mean to send the same patch text (but with an updated log
> message)?  Just making sure.
Yes, exactly.
> We are all imperfect human and anything we do is merely "trying to"

Fair point. :-) Do you want me to resend the patch without this part or is it ok ?

Thank you !
Le lun. 25 oct. 2021 à 17:55, Junio C Hamano <gitster@pobox.com> a écrit :
Show 37 quoted lines
>
> Robin Dupret <robin.dupret@gmail.com> writes:
>
> > Try to make reading the computation of the gzipped flag a bit more
> > natural.
>
> ... and did you succeed? ;-)
>
> We are all imperfect human and anything we do is merely "trying to",
> so let's not say "try to", unless the change is so involved that it
> is hard to judge if the result has succeeded in trying.
>
> Did you mean to send the same patch text (but with an updated log
> message)?  Just making sure.
>
> Thanks; will queue.
>
> > Signed-off-by: Robin Dupret <robin.dupret@hey.com>
> > ---
> >  http-backend.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/http-backend.c b/http-backend.c
> > index e7c0eeab23..3d6e2ff17f 100644
> > --- a/http-backend.c
> > +++ b/http-backend.c
> > @@ -466,9 +466,7 @@ static void run_service(const char **argv, int buffer_input)
> >       struct child_process cld = CHILD_PROCESS_INIT;
> >       ssize_t req_len = get_content_length();
> >
> > -     if (encoding && !strcmp(encoding, "gzip"))
> > -             gzipped_request = 1;
> > -     else if (encoding && !strcmp(encoding, "x-gzip"))
> > +     if (encoding && (!strcmp(encoding, "gzip") || !strcmp(encoding, "x-gzip")))
> >               gzipped_request = 1;
> >
> >       if (!user || !*user)
Previous: Junio C Hamano
Message 9 of 9 in “http-backend: remove a duplicated code branch”
  1. http-backend: remove a duplicated code branchRobin Dupret, Oct 11, 2021
  2. http-backend: remove a duplicated code branchRobin Dupret, Oct 11, 2021
  3. Jeff KingOct 12, 2021
  4. Ævar Arnfjörð BjarmasonOct 12, 2021
  5. Junio C HamanoOct 12, 2021
  6. Junio C HamanoOct 12, 2021
  7. http-backend: remove a duplicated code branchRobin Dupret, Oct 24, 2021
  8. Junio C HamanoOct 25, 2021
  9. Robin DupretOct 26, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.