git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] Making pathspec limited log play nicer with --first-parent

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Jan 19, 2012, 20:48 UTC
Message-ID
<CA+55aFyR02DyzwxrTdr360U+Pa6S3a40yBXegc_TuOsq_Z84qA@mail.gmail.com>
In-Reply-To
<7vwr8niftt.fsf@alter.siamese.dyndns.org>
On Thu, Jan 19, 2012 at 12:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> But I personally find your loop is even more disgusting
Yeah, I can't really argue with that.

The thing I was playing with was to move the entire loop content into a helper function (which would return the new pp), and then the "first-parent only" case just wouldn't do a loop at all.

But I couldn't be bothered. Your patch certainly does have the advantage of being minimally intrusive.

                  Linus
Previous: Junio C Hamano
Message 4 of 4 in “[RFC] Making pathspec limited log play nicer with --first-parent”
  1. Junio C HamanoJan 19, 2012
  2. Linus TorvaldsJan 19, 2012
  3. Junio C HamanoJan 19, 2012
  4. Linus TorvaldsJan 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.