From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Thu, 19 Jan 2012 20:48:46 GMT
Subject: Re: [RFC] Making pathspec limited log play nicer with --first-parent
Message-ID: <CA+55aFyR02DyzwxrTdr360U+Pa6S3a40yBXegc_TuOsq_Z84qA@mail.gmail.com>
In-Reply-To: <7vwr8niftt.fsf@alter.siamese.dyndns.org>

On Thu, Jan 19, 2012 at 12:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> But I personally find your loop is even more disgusting

Yeah, I can't really argue with that.

The thing I was playing with was to move the entire loop content into
a helper function (which would return the new pp), and then the
"first-parent only" case just wouldn't do a loop at all.

But I couldn't be bothered. Your patch certainly does have the
advantage of being minimally intrusive.

                  Linus