Re: [PATCH] Avoid infinite loop in malformed packfiles

From: ori@eigenstate.org <ori@eigenstate.org>
Date: Aug 31, 2020, 16:50 UTC
Message-ID: <C9978BD24477BD4A7FE2D3A014436D8D@eigenstate.org>
In-Reply-To: <20200831092946.GA2812764@coredump.intra.peff.net>

Show 19 quoted lines

> On Sun, Aug 30, 2020 at 09:15:10AM -0700, Junio C Hamano wrote:
> 
>> René Scharfe <l.s.r@web.de> writes:
>> 
>> >> Will that work? I'd expect that modern pack files end up being
>> >> offset deltas, rather than reference deltas.
>> >
>> > True, but going down all the way would work:
>> 
>> Perhaps, but I'd rather use pack-objects to prepare the repository
>> with no-delta-base-offset to force ref deltas.
> 
> Yeah, that seems like a much better test setup.
> 
> It does raise an interesting question, though. I had imagined we would
> limit the depth of all delta chains here, not just ref-deltas. But it is
> true that ofs deltas can't cycle. Without cycles, neither type can go on
> indefinitely (they are limited by the number of entries in the
> packfile). I could see arguments going either way:

Yeah -- that's what I'd implemented. I was just thinking that I'd want to test the issue that caused the problem in the first place, but it's the same code path either way.

I like the idea of limiting to the total number of objects in the pack. If we do that, we don't need a knob at all, since if we need more objects in the stack than are in the pack, it's obviously invalid.

That does eliminate an obvious way to test things, and we'd need to provide in an invalid pack file.