Re: [PATCH] Avoid infinite loop in malformed packfiles
- From
- ori@eigenstate.org <ori@eigenstate.org>
- Date
- Aug 30, 2020, 03:33 UTC
- Message-ID
- <A1CA9D499EDDACBA275BA61E114645F0@eigenstate.org>
- In-Reply-To
- <xmqqft8b3fj4.fsf@gitster.c.googlers.com>
Show 10 quoted lines
> Jeff King <peff@peff.net> writes: > >> It may be hard to test, as I suspect modern versions of Git are not >> happy to create such a deep chain. We could test with a lowered value of >> the config option, though. > > Yes, that was what I meant. Start from a 1KB text, create 50 > revisions of the file by adding a single line at its end at a time, > pack with depth limit of 100, and then see "git log -p" die when the > allowed max lowered to 10, or something like that.
Sorry about the delay -- most of my time to poke at this is over the weekend.
Will that work? I'd expect that modern pack files end up being offset deltas, rather than reference deltas.