git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] test: improve rebase -q test

From
Philip Oakley <philipoakley@iee.org>
Date
Jun 9, 2013, 22:44 UTC
Message-ID
<C30D5684C80641EFAC0F89F00B48A74F@PhilipOakley>
In-Reply-To
<CAMP44s38T9EUOe8EBKy1kxa-rEu7g0jb7+HB019AgCub+2SVnw@mail.gmail.com>
From: "Felipe Contreras" <felipe.contreras@gmail.com>
Sent: Sunday, June 09, 2013 8:33 PM
Show 27 quoted lines
> On Sun, Jun 9, 2013 at 2:20 PM, Junio C Hamano <gitster@pobox.com> 
> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Sun, Jun 9, 2013 at 1:30 PM, Junio C Hamano <gitster@pobox.com> 
>>> wrote:
>>>
>>>> --- a/t/test-lib-functions.sh
>>>> +++ b/t/test-lib-functions.sh
>>>> @@ -606,6 +606,18 @@ test_cmp() {
>>>>         $GIT_TEST_CMP "$@"
>>>>  }
>>>>
>>>> +# Check if the file expected to be empty is indeed empty, and 
>>>> barfs
>>>> +# otherwise.
>>>> +
>>>> +test_output_must_be_empty () {
>>>
>>> Why such a big name? test_empty() does the trick.
>>
>> Primarily in order to avoid that exact name "test_empty" that others
>> may want to use for a helper to check that the contents of a string
>> variable is empty.
>
> Which is never going to happen.
>

While folks do use such simplistic names, given that the patch had many call sites, I do think Filipe's short name would quickly become the accepted test name and not cause any great difficulties.

regards Philip

Previous: Junio C HamanoNext: Junio C Hamano
Message 21 of 24 in “Trivial patches”
  1. 0/3 Trivial patchesFelipe Contreras, Jun 7, 2013
  2. 1/3 sequencer: trivial fixFelipe Contreras, Jun 7, 2013
  3. Junio C HamanoJun 7, 2013
  4. Felipe ContrerasJun 7, 2013
  5. 2/3 test: improve rebase -q testFelipe Contreras, Jun 7, 2013
  6. Duy NguyenJun 8, 2013
  7. Felipe ContrerasJun 8, 2013
  8. Junio C HamanoJun 9, 2013
  9. Felipe ContrerasJun 9, 2013
  10. Junio C HamanoJun 9, 2013
  11. Felipe ContrerasJun 9, 2013
  12. Junio C HamanoJun 9, 2013
  13. Felipe ContrerasJun 9, 2013
  14. SZEDER GáborJun 10, 2013
  15. Junio C HamanoJun 10, 2013
  16. Felipe ContrerasJun 10, 2013
  17. SZEDER GáborJun 10, 2013
  18. Johannes SixtJun 10, 2013
  19. SZEDER GáborJun 10, 2013
  20. Junio C HamanoJun 10, 2013
  21. Philip OakleyJun 9, 2013
  22. Junio C HamanoJun 9, 2013
  23. Jeff KingJun 10, 2013
  24. 3/3 submodule: remove unnecessary checkFelipe Contreras, Jun 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.