[PATCH] Don't crash if ai_canonname comes back as null
- From
Augie Fackler <durin42@gmail.com>
- Date
- Apr 29, 2009, 23:04 UTC
- Message-ID
- <C2AC0D7A-3E11-4A3A-8447-5D7582547B13@gmail.com>
- In-Reply-To
- <81b0412b0904291504k3261df5fl692d09c6c761887e@mail.gmail.com>
Fixes a weird bug where git-daemon was segfaulting when started by sh(1) because ai_canonname was null. --- Fixed based on feedback.
daemon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/daemon.c b/daemon.c index 13401f1..ae21d92 100644 --- a/daemon.c +++ b/daemon.c @@ -459,7 +459,7 @@ static void parse_extra_args(char *extra_args, int buflen) inet_ntop(AF_INET, &sin_addr->sin_addr, addrbuf, sizeof(addrbuf)); free(canon_hostname); - canon_hostname = xstrdup(ai->ai_canonname); + canon_hostname = ai->ai_canonname ? xstrdup(ai->ai_canonname) : NULL; free(ip_address); ip_address = xstrdup(addrbuf); break;
-- 1.6.2.GIT