Re: [PATCH] Workaround for ai_canonname sometimes coming back as null

From: Alex Riesen <raa.lkml@gmail.com>
Date: Apr 29, 2009, 21:56 UTC
Message-ID: <81b0412b0904291456h6e6fa2f0h840e7b3569573be0@mail.gmail.com>
In-Reply-To: <81b0412b0904291455n47f83e9ftcbdec0ff1c0ea03@mail.gmail.com>

2009/4/29 Alex Riesen <raa.lkml@gmail.com>:

Show 15 quoted lines

> 2009/4/29 Augie Fackler <durin42@gmail.com>:
>> @@ -459,7 +459,10 @@ static void parse_extra_args(char *extra_args, int
>> buflen)
>>                                inet_ntop(AF_INET, &sin_addr->sin_addr,
>>                                          addrbuf, sizeof(addrbuf));
>>                                free(canon_hostname);
>> -                               canon_hostname = xstrdup(ai->ai_canonname);
>> +                               if (ai->ai_canonname)
>> +                                       canon_hostname =
>> xstrdup(ai->ai_canonname);
>> +                               else
>> +                                       canon_hostname = "unknown";
>
> This last line will crash some lines down, when canon_hostname is free'd:
>

Actually, it will crash in the line just above. On the same reasons.