Re: [PATCH 0/2] [RFD] Using gitrevisions :/search style with other operators
- From
Kevin Ballard <kevin@sb.org>
- Date
- Dec 9, 2010, 01:46 UTC
- Message-ID
- <C1C51028-60B5-46EE-B172-1A9330FBBB8A@sb.org>
- In-Reply-To
- <AANLkTin1SjEzBnLd-HK9fANShLezAKHAOai9MyF-cuoT@mail.gmail.com>
On Dec 8, 2010, at 5:42 PM, Nguyen Thai Ngoc Duy wrote:
Show 20 quoted lines
> On Thu, Dec 9, 2010 at 7:44 AM, Jakub Narebski <jnareb@gmail.com> wrote:
>> On Thu, 9 Dec 2010, Nguyen Thai Ngoc Duy wrote:
>>> 2010/12/9 Jakub Narebski <jnareb@gmail.com>:
>>
>>>> I wonder if it would be possible to make :/<regex> (which looks a bit
>>>> like searching the index) to be an alias to --all^{/<regex>}...
>>>
>>> It looks a bit strange to my eyes to merge normal option name with
>>> revision syntax. But I think it's possible. Do we allow branch/tag
>>> name with leading '-'?
>>
>> Well, with below proposal it would simply be
>>
>> --all ^{/<regexp>}
>
> This hardly works with range and may conflict with "--all" being
> already used by some commands.
>
> I think we can move '/' out of {}, the space between '/' and '{' can
> be used for optional parameters: ^/{foo}I thought ^{} was going to be an arbitrary grouping operator, capable of embedding any other modifier, but primarily only useful for regex. This change explicitly makes it an alternative regex syntax.
-Kevin Ballard