git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Trivial path quoting fixes in git-instaweb

From
Sean Estabrooks <seanlkml@sympatico.ca>
Date
Jul 18, 2009, 16:45 UTC
Message-ID
<BLU0-SMTP74459FFFD6FF936D27AD4FAE1F0@phx.gbl>
In-Reply-To
<4A61E563.7000401@superdigi.de>
Bodo Schlecht noticed that Instaweb didn't propely quote all
path instances in the Apache config file it generated.
---
 git-instaweb.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-instaweb.sh b/git-instaweb.sh
index 5f4419b..32f6496 100755
--- a/git-instaweb.sh
+++ b/git-instaweb.sh
@@ -256,7 +256,7 @@ apache2_conf () {
 	mkdir -p "$GIT_DIR/gitweb/logs"
 	bind=
 	test x"$local" = xtrue && bind='127.0.0.1:'
-	echo 'text/css css' > $fqgitdir/mime.types
+	echo 'text/css css' > "$fqgitdir/mime.types"
 	cat > "$conf" <<EOF
 ServerName "git-instaweb"
 ServerRoot "$fqgitdir/gitweb"
@@ -272,7 +272,7 @@ EOF
 		fi
 	done
 	cat >> "$conf" <<EOF
-TypesConfig $fqgitdir/mime.types
+TypesConfig "$fqgitdir/mime.types"
 DirectoryIndex gitweb.cgi
 EOF
 
-- 
1.6.3.3
Previous: Bodo SchlechtNext: Eric Wong
Message 2 of 3 in “instaweb does not start because of a small syntax error in .git/gitweb/httpd.conf”
  1. Bodo SchlechtJul 18, 2009
  2. Trivial path quoting fixes in git-instawebSean Estabrooks, Jul 18, 2009
  3. Eric WongJul 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.