Re: [PATCH] Trivial path quoting fixes in git-instaweb
Sean Estabrooks <seanlkml@sympatico.ca> wrote:
>
> Bodo Schlecht noticed that Instaweb didn't propely quote all
> path instances in the Apache config file it generated.
Works for me here, thank you.
Acked-by: Eric Wong <normalperson@yhbt.net>
Show 27 quoted lines
> ---
> git-instaweb.sh | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 5f4419b..32f6496 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -256,7 +256,7 @@ apache2_conf () {
> mkdir -p "$GIT_DIR/gitweb/logs"
> bind=
> test x"$local" = xtrue && bind='127.0.0.1:'
> - echo 'text/css css' > $fqgitdir/mime.types
> + echo 'text/css css' > "$fqgitdir/mime.types"
> cat > "$conf" <<EOF
> ServerName "git-instaweb"
> ServerRoot "$fqgitdir/gitweb"
> @@ -272,7 +272,7 @@ EOF
> fi
> done
> cat >> "$conf" <<EOF
> -TypesConfig $fqgitdir/mime.types
> +TypesConfig "$fqgitdir/mime.types"
> DirectoryIndex gitweb.cgi
> EOF
>
> --