Re: [PATCH] git-send-email: Generalize auto-cc recipient mechanism.

From: Sean <seanlkml@sympatico.ca>
Date: Dec 26, 2007, 04:54 UTC
Message-ID: <BAYC1-PASMTP131135B69209F6EB72F809AE5B0@CEZ.ICE>
In-Reply-To: <1198641389-959-1-git-send-email-git@davidb.org>

On Tue, 25 Dec 2007 19:56:29 -0800 David Brown <git@davidb.org> wrote:

Show 13 quoted lines

> Add a new option --suppress-cc, which can be specified one or more
> times to list the categories of auto-cc fields that should be
> suppressed.  If not specified, it defaults to values to give the same
> behavior as specified by --suppress-from, and --signed-off-cc.  The
> categories are:
> 
>   self   - patch sender.  Same as --suppress-from.
>   author - patch author.
>   cc     - cc lines mentioned in the patch.
>   cccmd  - avoid running the cccmd.
>   sob    - signed off by lines.
>   all    - all non-explicit recipients
>

Hi Dave,

It's great to see you're taking care of this issue, it's one that i've tripped over a few times. If your patch is accepted as-is, i think it's an improvement.

But i wonder about the case where a user has "sendemail.suppresscc = all" in their ~/.gitconfig. For the occasion when they do want to cc the author of a patch, what do they do? The above UI seems to lack a way to enable a cc option that has been disabled by default.

Cheers, Sean