Re: [PATCH] git-send-email: Add --suppress-all-from option.

From: Theodore Tso <tytso@mit.edu>
Date: Dec 22, 2007, 00:55 UTC
Message-ID: <20071222005504.GD8601@thunk.org>
In-Reply-To: <20071221192120.GA13171@mail.oracle.com>

On Fri, Dec 21, 2007 at 11:21:20AM -0800, Joel Becker wrote:

Show 12 quoted lines

> 	Yay, even better that we're going to evaluate the sucker (I was
> just complaining about this yesterday to someone, so how apropos that it
> comes up on-list).
> 	First and foremost, I think git-send-email should not default to
> anything.  It was quite a surprise, the first time I tried to use it, to
> discover I had to add two options to ~/.gitconfig just for sane
> behavior.  Never mind that I couldn't suppress the author-cc.  I think
> that a naive "git send-email --to bob@bob.com foo.patch" should only go
> to bob, period.
> 	We can then add ways to auto-cc.  I don't mind typing the extra
> bits.  Heck, we could even define a --review that does what is currently
> the default - cc-everyone-who-might-care-as-we-go-upstream.

Where e-mail addresses are used by default by git-send-email should probably be a git configuration option (and then we will need to document the heck out of this when we change it, so this is probably a git-1.6.0 thing), so projects can tell all of their contributors if they need to make changes in their config file for the proper defaults. Right now the defaults are more or less perfect for the Linux Kernel development processes, but other folks might not like them. On the flip side, just removing all of the current auto-cc's would be awfully inconvenient for the Linux kernel development community.

						- Ted