Re: Test 9500 - unhelpful without Perl::CGI

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jun 15, 2011, 18:36 UTC
Message-ID: <BANLkTineU1x8NDk7Q5eUN3rkg0=yPH2k=w@mail.gmail.com>
In-Reply-To: <7vei2vja8q.fsf@alter.siamese.dyndns.org>

On Wed, Jun 15, 2011 at 10:05 AM, Junio C Hamano <gitster@pobox.com> wrote:

>
> Subject: [PATCH] t/gitweb-lib.sh: skip gitweb tests when perl dependencies are not met

Looks good. This makes t9500 go from

   not ok - 1 no commits: projects_list (implicit)
   #	gitweb_run
   not ok - 2 no commits: projects_index
   #	gitweb_run "a=project_index"
   not ok - 3 no commits: .git summary (implicit)
   #	gitweb_run "p=.git"
   not ok - 4 no commits: .git commit (implicit HEAD)
   ...
   not ok - 98 categories: projects list, only default category
   #	echo "\$projects_list_group_categories = 1;" >>gitweb_config.perl &&
   #		 gitweb_run
   # failed 91 among 98 test(s)
   1..98

to

  # passed all 0 test(s)
  1..0 # SKIP skipping gitweb tests, CGI module unusable

without perl-CGI installed. And with perl-CGI installed I obviously get

   ...
   ok 97 - ctags: malformed tag weights
   ok 98 - categories: projects list, only default category
   # passed all 98 test(s)
   1..98

So Ack on that patch.

   Thanks,
                           Linus