Re: Test 9500 - unhelpful without Perl::CGI

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2011, 16:51 UTC
Message-ID: <7vips7jaws.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BANLkTinAfqysABm+t_NkOGO2U+iy57WbVQ@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

Show 9 quoted lines

> On Wed, Jun 15, 2011 at 07:59, Junio C Hamano <gitster@pobox.com> wrote:
>> +perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
>> +       skip_all='skipping gitweb tests, CGI module unusable'
>> +       test_done
>> +}
>> +
>
> Isn't the new style to use test_must_succeed CGI_AVAILABLE '...' '...'
> rather than skip_all+test_done?

I do not think that adds any value, at least in this case. Besides, look at the context line above what you quoted ;-)