Re: [PATCH 10/51] i18n: git-am core say messages

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 3, 2011, 17:35 UTC
Message-ID: <BANLkTinYVRcar0m-d5ZC=7RbputR5AbZ3A@mail.gmail.com>
In-Reply-To: <m3ei5j44wz.fsf@localhost.localdomain>

On Sun, Apr 3, 2011 at 19:33, Jakub Narebski <jnareb@gmail.com> wrote:

Show 17 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> Make the core git-am messages that use say() translatable. These are
>> visible on almost every git am invocation.
>>
>> There are tests that depend on the "Applying" output that need to be
>> skipped along with this translation.
>
>
>> -     say "Applying: $FIRSTLINE"
>> +     say "$(eval_gettext "Applying: \$FIRSTLINE")"
>
>> -                     say No changes -- Patch already applied.
>> +                     say "$(gettext "No changes -- Patch already applied.")"
>
> I guess that you canot simply make 'say' to do the translation because
> one doesn't know if getext or eval_gettext is needed, isn't it?

Indeed, the xgettext() rule couldn't tell the difference. And even if we only used say() for gettext() I'd prefer not to make things more complex by supporting gettext extraction from our own custom functions. I'd like to be able to grep for gettext and get all the invocations.