git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 10/51] i18n: git-am core say messages

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 3, 2011, 16:45 UTC
Message-ID
<1301849175-1697-11-git-send-email-avarab@gmail.com>
In-Reply-To
<1301849175-1697-1-git-send-email-avarab@gmail.com>

Make the core git-am messages that use say() translatable. These are visible on almost every git am invocation.

There are tests that depend on the "Applying" output that need to be skipped along with this translation.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-am.sh           |    6 +++---
 t/t4150-am.sh       |    5 ++++-
 t/t4151-am-abort.sh |    2 +-
 3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/git-am.sh b/git-am.sh
index 2c8770b..a15c5cc 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -739,7 +739,7 @@ To restore the original branch and stop patching run \"\$cmdline --abort\"."; ec
 		stop_here $this
 	fi
 
-	say "Applying: $FIRSTLINE"
+	say "$(eval_gettext "Applying: \$FIRSTLINE")"
 
 	case "$resolved" in
 	'')
@@ -784,7 +784,7 @@ did you forget to use 'git add'?"; echo
 		    # Applying the patch to an earlier tree and merging the
 		    # result may have produced the same tree as ours.
 		    git diff-index --quiet --cached HEAD -- && {
-			say No changes -- Patch already applied.
+			say "$(gettext "No changes -- Patch already applied.")"
 			go_next
 			continue
 		    }
@@ -810,7 +810,7 @@ did you forget to use 'git add'?"; echo
 			GIT_AUTHOR_DATE=
 		fi
 		parent=$(git rev-parse --verify -q HEAD) ||
-		say >&2 "applying to an empty history"
+		say >&2 "$(gettext "applying to an empty history")"
 
 		if test -n "$committer_date_is_author_date"
 		then
diff --git a/t/t4150-am.sh b/t/t4150-am.sh
index 850fc96..aa3d4ad 100755
--- a/t/t4150-am.sh
+++ b/t/t4150-am.sh
@@ -464,7 +464,10 @@ test_expect_success 'am newline in subject' '
 	git checkout first &&
 	test_tick &&
 	sed -e "s/second/second \\\n foo/" patch1 >patchnl &&
-	git am <patchnl >output.out 2>&1 &&
+	git am <patchnl >output.out 2>&1
+'
+
+test_expect_success C_LOCALE_OUTPUT 'output: am newline in subject' '
 	grep "^Applying: second \\\n foo$" output.out
 '
 
diff --git a/t/t4151-am-abort.sh b/t/t4151-am-abort.sh
index c95c4cc..b9d8f5e 100755
--- a/t/t4151-am-abort.sh
+++ b/t/t4151-am-abort.sh
@@ -43,7 +43,7 @@ do
 		test_cmp expect actual
 	'
 
-	test_expect_success "am$with3 --skip continue after failed am$with3" '
+	test_expect_success C_LOCALE_OUTPUT "am$with3 --skip continue after failed am$with3" '
 		test_must_fail git am$with3 --skip >output &&
 		test "$(grep "^Applying" output)" = "Applying: 6" &&
 		test_cmp file-2-expect file-2 &&
-- 
1.7.4.1
Previous: Ævar Arnfjörð BjarmasonNext: Jakub Narebski
Message 11 of 59 in “i18n: Shell script translations”
  1. 00/51 i18n: Shell script translationsÆvar Arnfjörð Bjarmason, Apr 3, 2011
  2. 01/51 i18n: git-am add git-sh-i18nÆvar Arnfjörð Bjarmason, Apr 3, 2011
  3. 02/51 i18n: git-am one-line gettext $msg; echoÆvar Arnfjörð Bjarmason, Apr 3, 2011
  4. 03/51 i18n: git-am multi-line getttext $msg; echoÆvar Arnfjörð Bjarmason, Apr 3, 2011
  5. 04/51 i18n: git-am eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  6. 05/51 i18n: git-am echo + gettext messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  7. 06/51 i18n: git-am die messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  8. 07/51 i18n: git-am cannot_fallback messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  9. 08/51 i18n: git-am clean_abort messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  10. 09/51 i18n: git-am "Apply?" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  11. 10/51 i18n: git-am core say messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  12. Jakub NarebskiApr 3, 2011
  13. Ævar Arnfjörð BjarmasonApr 3, 2011
  14. 11/51 i18n: git-am printf(1) message to eval_gettextÆvar Arnfjörð Bjarmason, Apr 3, 2011
  15. 12/51 i18n: git-pull add git-sh-i18nÆvar Arnfjörð Bjarmason, Apr 3, 2011
  16. 13/51 i18n: git-pull die messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  17. Ævar Arnfjörð BjarmasonApr 3, 2011
  18. 14/51 i18n: git-pull eval_gettext + die messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  19. 15/51 i18n: git-pull eval_gettext + warning messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  20. 16/51 i18n: git-pull split up "no candidate" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  21. 17/51 i18n: git-pull "You asked to pull" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  22. 18/51 i18n: git-pull "[...] not currently on a branch" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  23. 19/51 i18n: git-pull "rebase against" / "merge with" messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  24. Martin von ZweigbergkApr 3, 2011
  25. Ævar Arnfjörð BjarmasonApr 4, 2011
  26. 20/51 i18n: git-submodule add git-sh-i18nÆvar Arnfjörð Bjarmason, Apr 3, 2011
  27. 21/51 i18n: git-submodule echo + eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  28. 22/51 i18n: git-submodule say + eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  29. 23/51 i18n: git-submodule die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  30. 24/51 i18n: git-submodule $update_module say + die messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  31. 25/51 i18n: git-submodule "cached cannot be used" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  32. 26/51 i18n: git-submodule "Submodule change[...]" messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  33. 27/51 i18n: git-submodule $errmsg messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  34. 28/51 i18n: git-submodule "Entering [...]" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  35. 29/51 i18n: git-submodule "[...] path is ignored" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  36. 30/51 i18n: git-submodule "path not initialized" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  37. 31/51 i18n: git-submodule "blob" and "submodule" messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  38. 32/51 i18n: git-stash add git-sh-i18nÆvar Arnfjörð Bjarmason, Apr 3, 2011
  39. 33/51 i18n: git-stash echo + gettext messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  40. 34/51 i18n: git-stash say + gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  41. 35/51 i18n: git-stash die + gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  42. 36/51 i18n: git-stash die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  43. 37/51 i18n: git-stash die + eval_gettext $* messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  44. 38/51 i18n: git-stash die + eval_gettext $1 messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  45. 39/51 i18n: git-stash "unknown option" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  46. 40/51 i18n: git-stash drop_stash say/die messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  47. 41/51 i18n: git-bisect add git-sh-i18nÆvar Arnfjörð Bjarmason, Apr 3, 2011
  48. 42/51 i18n: git-bisect gettext + echo messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  49. 43/51 i18n: git-bisect echo + gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  50. 44/51 i18n: git-bisect echo + eval_gettext messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  51. 45/51 i18n: git-bisect die + gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  52. 46/51 i18n: git-bisect die + eval_gettext messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  53. 47/51 i18n: git-bisect bisect_run + $@ messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  54. 48/51 i18n: git-bisect bisect_reset + $1 messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  55. 49/51 i18n: git-bisect bisect_replay + $1 messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  56. 50/51 i18n: git-bisect [Y/n] messagesÆvar Arnfjörð Bjarmason, Apr 3, 2011
  57. 51/51 i18n: git-bisect bisect_next_check "You need to" messageÆvar Arnfjörð Bjarmason, Apr 3, 2011
  58. Junio C HamanoApr 3, 2011
  59. Ævar Arnfjörð BjarmasonApr 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.